Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colossus: Rework sync and cleanup #5194

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Nov 25, 2024

  • Optimizations: The way data objects / data object ids are queried and processed during sync and cleanup has been optimized:
    • DataObjectDetailsLoader and DataObjectIdsLoader were implemented. They allow loading data objects / data object ids in batches using a connection query and avoid fetching redundant data from the GraphQL server.
    • Sync and cleanup services now process tasks in batches of 10_000 to avoid overflowing the memory.
    • Synchronous operations like sort or filter on larger arrays of data objects have been optimized (for example, by replacing .filter(Array.includes(...)) with .filter(Set.has(...))).
  • A safety mechanism was added to avoid removing "deleted" objects for which a related DataObjectDeleted event cannot be found in storage squid.
  • Improved logging during cleanup.

@Lezek123 Lezek123 marked this pull request as draft November 25, 2024 18:44
@Lezek123 Lezek123 marked this pull request as ready for review November 28, 2024 08:14
@Lezek123 Lezek123 changed the title Colossus: Rework sync and cleanup (WIP) Colossus: Rework sync and cleanup Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant